[PATCH] D35275: [Sanitizers] ASan/MSan/LSan allocators set errno on failure.

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 18:08:22 PDT 2017


cryptoad added a comment.

Instead of the ptr_check calls, couldn't errno be set to ENOMEM in ReturnNullOrDieOnFailure::OnOOM? Unless mistaken it should be the common function to the return nullptr scenario on OOM.
Also you are going to hate me, and I apologize in advance, but when starting Scudo I was asked to follow to LLVM casing scheme, which your additions to Scudo don't comply with :/


https://reviews.llvm.org/D35275





More information about the llvm-commits mailing list