[PATCH] D34685: Mark a number of x86 only tests to require x86

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 15:09:17 PDT 2017


ruiu added a comment.

Again, can you please update as per the Rafael's comment?

> Does this mean the patch for files in the ELF directory which do not start with a target name should not specify a triple?
>  For example, relocatable-tls.s and no-symtab.s should pass without the REQUIRES clause were the explicit triple removed.

Here is the rule that I'm proposing.

- If a test is testing an architecture-specific feature, add the architecture name as a prefix. For example, if a test tests x86 relocation relaxation, name it x86-relocation-relaxation.s.
- If a test is testing an architecture-independent feature, use the x86 as a "generic" target, and don't add "x86" as a prefix.


https://reviews.llvm.org/D34685





More information about the llvm-commits mailing list