[PATCH] D35207: [ELF] - Give a symbol version extracted from name a priority over version set by script.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 12:01:27 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/SymbolTable.cpp:705
>      Symbol *Sym = B->symbol();
>      if (Sym->InVersionScript)
>        warn("duplicate symbol '" + Ver.Name + "' in version script");
> ----------------
> Can you replace this with
>
>   if (Sym->VersionId != Config->DefaultSymbolVersion)
>
> to remove `Symbol::InVersionScript`?

Excellent idea. Since the field was already in trunk, I removed it in
r307690.

Thanks,
Rafael


More information about the llvm-commits mailing list