[PATCH] D35115: Clang's assembler crashes if Scale in lea is negative (pr33661)

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 08:21:35 PDT 2017


avt77 added inline comments.


================
Comment at: test/MC/X86/intel-syntax-invalid-scale.s:12
     lea rax, [rdi + rdx*16]
+// CHECK: error: unknown token in expression
+    lea rax, [rdi + rdx*-8]
----------------
RKSimon wrote:
> avt77 wrote:
> > RKSimon wrote:
> > > Any idea why this error message is different? Is it worth fixing?
> > gcc produces the same message like above 3 ones but Clang does what we see. Clang does it automatically (without any my intervation) that's why I decided don't touch it. But I could try to fix.
> Do you think you can easily add it to this patch or would it be better to separate it as a follow up patch?
I'm no sure it's easy but I'll try to do it tomorrow. If I fail...


https://reviews.llvm.org/D35115





More information about the llvm-commits mailing list