[PATCH] D35202: [X86] lea rdx, [rax - one] adds one instead of subtracts when one is a symbol that has been .set (PR33667)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

Couple of minors



================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1513
+  if (ImmVal || !Disp) {
     const MCExpr *Imm = MCConstantExpr::create(SM.getImm(), getContext());
+    if (Disp && ImmVal && Disp->getKind() == llvm::MCExpr::SymbolRef)
----------------
Replace SM.getImm() with ImmVal?


================
Comment at: test/MC/X86/intel-syntax.s:20
+  lea rdx, [rax + number]
+  lea rdx, [number + rax]
+
----------------
Interleave the CHECKs with the relevant instruction


https://reviews.llvm.org/D35202