[PATCH] D35209: [ARM] Unify handling of M-Class system registers

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 03:41:41 PDT 2017


john.brawn added a comment.

ARMISelDAGToDAG.cpp and ARMAsmParser.cpp have essentially duplicate code for mapping the register name to the register enum, instead they should both call a function to handle it. I'm not sure where it would go though, maybe ARMBaseRegisterInfo? It would also make sense to move the reverse mapping (done by ARMInstPrinter.cpp) there as well so you only need to modify one file when adding a new register.


https://reviews.llvm.org/D35209





More information about the llvm-commits mailing list