[llvm] r271491 - [LibFuzzer] Reimplement how the optional user functions are called.

Dan Liew via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 11 03:06:56 PDT 2017


On 10 July 2017 at 21:27, Eric Christopher <echristo at gmail.com> wrote:
>
>
> On Sat, Jul 8, 2017 at 11:32 AM Dan Liew <dan at su-root.co.uk> wrote:
>>
>> On 8 July 2017 at 01:40, Eric Christopher <echristo at gmail.com> wrote:
>> > Hi Dan,
>> >
>> > So this is causing warnings and breaking Werror builds:
>> >
>> >
>> > /usr/local/google/home/echristo/sources/llvm/lib/Fuzzer/FuzzerExtFunctions.def:29:10:
>> > warning: ISO C++ forbids casting between pointer-to-function and
>> > pointer-to-object [-Wpedantic]
>> >  EXT_FUNC(__lsan_enable, void, (), false);
>> >           ^
>> >
>> > /usr/local/google/home/echristo/sources/llvm/lib/Fuzzer/FuzzerExtFunctionsWeak.cpp:44:24:
>> > note: in definition of macro ‘EXT_FUNC’
>> >    CheckFnPtr((void *)::NAME, #NAME, WARN);
>> >                         ^
>> >
>> > Feel like fixing? :)
>>
> I have no preferences, but would appreciate you fixing it if possible.
>
> Thanks
>
> -eric

I'm not able to reproduce this with Clang 4.0, nor with GCC 7.1.1 (20170528).

The only warning I'm seeing for LibFuzzer with GCC  is

``
+ g++ -Wall -Wpedantic -g -O2 -fno-omit-frame-pointer -std=c++11
./FuzzerIOWindows.cpp -c
./FuzzerIOWindows.cpp:185:1: warning: multi-line comment [-Wcomment]
 // Parse a directory ending in separator, like: SomeDir\
 ^
./FuzzerIOWindows.cpp:200:1: warning: multi-line comment [-Wcomment]
 // Parse a servername and share, like: SomeServer\SomeShare\
 ^
```

I'm going to try with an older GCC and failing that I'll try David's
suggestion of Clang ToT.


More information about the llvm-commits mailing list