[PATCH] D33048: [CMake] runtimes test targets need to depend on LLVM tools

[Petr Hosek via Phabricator via llvm-commits]

phosek added a comment.

@george.karpenkov I was just rebasing https://reviews.llvm.org/D32816 on top of your change and while running tests, I saw errors in CMake. So I tried building building ToT and I'm still seeing the same error:

  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "check-runtimes" does not exist.
  
  
  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "check-unwind" does not exist.
  
  
  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "check-cxxabi" does not exist.
  
  
  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "check-cxx" does not exist.
  
  
  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "check-compiler-rt" does not exist.
  
  
  CMake Error at runtimes/CMakeLists.txt:311 (add_dependencies):
    The dependency target "asan" of target "runtimes-test-depends" does not
    exist.

Looking at the error and your change, I'm not sure if asan should be in the `RUNTIME_TEST_DEPENDS` list, since `asan` target is only built as part of the runtimes build and as such isn't available as a dependency until after you've done a runtimes build.


Repository:
  rL LLVM

https://reviews.llvm.org/D33048