[PATCH] D35166: [DWARF] Introduce verification for the unit header chain in .debug_info section to llvm-dwarfdump.

Spyridoula Gravani via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 17:24:04 PDT 2017


sgravani marked 3 inline comments as done.
sgravani added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:39
+
+  uint32_t Offset = 4;
+  uint16_t Version = DebugInfoData.getU16(&Offset);
----------------
probinson wrote:
> This is assuming DWARF-32 format.  It's okay to support only one format, if you have a check for DWARF-64 and explicitly reject it.
I'm stopping verification if I detect a unit with 64-bit format (without generating error).
Thanks!


https://reviews.llvm.org/D35166





More information about the llvm-commits mailing list