[PATCH] D35098: [asan] For iOS/AArch64, if the dynamic shadow doesn't fit, restrict the VM space

[Aleksey Shlyapnikov via Phabricator via llvm-commits]

alekseyshl added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_nolibc.cc:41
+}
+#endif
+
----------------
kubamracek wrote:
> alekseyshl wrote:
> > kubamracek wrote:
> > > alekseyshl wrote:
> > > > I wonder what target fails without this definition?
> > > Actually, it's safestack.a, which uses sanitizer_common, but links in a nolibc mode.
> > I presume it's RestrictMemoryToMaxAddress what needs MmapFixedNoAccess. How about moving it into sanitizer_mac_libcdep.cc?
> sanitizer_mac_libcdep.cc doesn't currently exist... Do you want me to create it?
Yes, please do create it, it seems like a cleaner solution than an unreachable function.


https://reviews.llvm.org/D35098