[PATCH] D35224: [lld/pdb] Create an empty public symbol records stream

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 15:03:06 PDT 2017


zturner created this revision.
Herald added subscribers: hiraditya, mgorny.

This creates a public symbol hash stream and public symbol records stream, each completely empty.  This allows us to get more fields matching up in the pdb diff test, so that test is updated.

Eventually we will need to come up with a clever algorithm for diffing symbol //records//, but for now at least this gets us one step closer.

link still doesn't like our PDBs even after this change, so the next thing to check would be creating an empty globals stream.


https://reviews.llvm.org/D35224

Files:
  lld/COFF/PDB.cpp
  lld/test/COFF/pdb-diff.test
  llvm/include/llvm/DebugInfo/PDB/Native/DbiStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/PublicsStream.h
  llvm/include/llvm/DebugInfo/PDB/Native/PublicsStreamBuilder.h
  llvm/include/llvm/DebugInfo/PDB/Native/RawTypes.h
  llvm/lib/DebugInfo/PDB/CMakeLists.txt
  llvm/lib/DebugInfo/PDB/Native/DbiStreamBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
  llvm/lib/DebugInfo/PDB/Native/PublicsStream.cpp
  llvm/lib/DebugInfo/PDB/Native/PublicsStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35224.105925.patch
Type: text/x-patch
Size: 15762 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170710/f5171e82/attachment.bin>


More information about the llvm-commits mailing list