[PATCH] D35214: [compiler-rt][X86] Match the detection of cpu's for __cpu_model to the latest version of gcc

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 13:12:59 PDT 2017


echristo added a comment.

In https://reviews.llvm.org/D35214#804024, @craig.topper wrote:

> I can't remove the older processors from Host.cpp. Host.cpp also contains a newer processor called Goldmont that's not in libgcc yet. I think these files have slightly different goals.


Gah.

They're not supposed to fwiw.

I'll trust you here, but can you make sure that the code in Host.cpp is as up to date with all of this as you can make it? If nothing else Host.cpp should be a strict superset of this.

-eric


https://reviews.llvm.org/D35214





More information about the llvm-commits mailing list