[llvm] r307568 - [docs] Remove obsolete section in CMake documentation.

George Karpenkov via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 11:56:51 PDT 2017


Author: george.karpenkov
Date: Mon Jul 10 11:56:51 2017
New Revision: 307568

URL: http://llvm.org/viewvc/llvm-project?rev=307568&view=rev
Log:
[docs] Remove obsolete section in CMake documentation.

Differential Revision: https://reviews.llvm.org/D35023

Modified:
    llvm/trunk/docs/CMakePrimer.rst

Modified: llvm/trunk/docs/CMakePrimer.rst
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CMakePrimer.rst?rev=307568&r1=307567&r2=307568&view=diff
==============================================================================
--- llvm/trunk/docs/CMakePrimer.rst (original)
+++ llvm/trunk/docs/CMakePrimer.rst Mon Jul 10 11:56:51 2017
@@ -112,33 +112,6 @@ In this example the ``extra_sources`` va
 targeting an Apple platform. For all other targets the ``extra_sources`` will be
 evaluated as empty before add_executable is given its arguments.
 
-One big "Gotcha" with variable dereferencing is that ``if`` commands implicitly
-dereference values. This has some unexpected results. For example:
-
-.. code-block:: cmake
-
-   if("${SOME_VAR}" STREQUAL "MSVC")
-
-In this code sample MSVC will be implicitly dereferenced, which will result in
-the if command comparing the value of the dereferenced variables ``SOME_VAR``
-and ``MSVC``. A common workaround to this solution is to prepend strings being
-compared with an ``x``.
-
-.. code-block:: cmake
-
-   if("x${SOME_VAR}" STREQUAL "xMSVC")
-
-This works because while ``MSVC`` is a defined variable, ``xMSVC`` is not. This
-pattern is uncommon, but it does occur in LLVM's CMake scripts.
-
-.. note::
-   
-   Once the LLVM project upgrades its minimum CMake version to 3.1 or later we
-   can prevent this behavior by setting CMP0054 to new. For more information on
-   CMake policies please see the cmake-policies manpage or the `cmake-policies
-   online documentation
-   <https://cmake.org/cmake/help/v3.4/manual/cmake-policies.7.html>`_.
-
 Lists
 -----
 




More information about the llvm-commits mailing list