[PATCH] D35189: Add GUID-ValueID map and original name to ThinLTO summary.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D35189#803910, @haojiewang wrote:

> In https://reviews.llvm.org/D35189#803332, @mehdi_amini wrote:
>
> > The context and the motivation is *still* not clear to me. To begin why do we need the *names* when doing the thin link?
>
>
> We need the GUID because it is needed when we build the combined index in thin link phase. We need ValueId is because the size of GUID is too large so that we do not want to write it everywhere, so we set a ValueId which is indexing from 0. And we should also set a GUID to ValueId map to record the mapping between them. 
>  We need the original name because it is needed in FunctionImport. So we should pass is to thin link phase.


You manage to not really answer fully my question here. But I think infer it from the code in my previous inline comment, it is "we need the name to recompute a GUID for internal symbol promoted to global", correct?


https://reviews.llvm.org/D35189