[PATCH] D35027: [PowerPC] Reduce register pressure by not materializing a constant just for use as an index register for X-Form loads/stores

[Lei Huang via Phabricator via llvm-commits]

lei added a comment.

In https://reviews.llvm.org/D35027#801638, @hfinkel wrote:

> In https://reviews.llvm.org/D35027#801305, @echristo wrote:
>
> > In https://reviews.llvm.org/D35027#801294, @sfertile wrote:
> >
> > > Regarding the isIntS16Immediate change, the function is duplicated in PPCISelDAGToDAG.cpp as well. I suggest we leave it as is in this patch, and then in a separate patch common up the definitions and change it to use an int16_t argument. That keeps this patch focused on only doing a single thing, and puts the code cleanup in its own NFC patch.
> >
> >
> > Feel free to do that first. :)
>
>
> Yes, please split this into two patches. Change the int16_t first, and then commit the functional change. LGTM.


NFC patch committed: SVN-307442


https://reviews.llvm.org/D35027