[PATCH] D35114: Fix invalid cast in instcombine UMul/ZExt idiom

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.

LGTM with small remark.



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:3849
         // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
-        ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
-        APInt ShortMask = CI->getValue().trunc(MulWidth);
+        auto ShortMask = Builder->CreateTrunc(BO->getOperand(1),
+                                              Builder->getIntNTy(MulWidth));
----------------
Explicit type instead of auto would improve readability.


Repository:
  rL LLVM

https://reviews.llvm.org/D35114