[PATCH] D35192: [ARM] Use ADDCARRY / SUBCARRY

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 03:40:23 PDT 2017


deadalnix added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:4007
+  case ISD::USUBO:
+    {
+    Value = DAG.getNode(ARMISD::SUBC, dl, VTs, LHS, RHS);
----------------
Usual style is more like

  case Foo: {
    ...
  }


================
Comment at: test/CodeGen/ARM/intrinsics-overflow.ll:12
+  ; CHEC: mov r[[R2:[0-9]+]], #0
+  ; CHEC: adc r[[R0]], r[[R2]], #0
 }
----------------
CHECK


https://reviews.llvm.org/D35192





More information about the llvm-commits mailing list