[PATCH] D34993: Hack to keep __real_foo

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 02:08:27 PDT 2017


jhenderson added subscribers: bd1976llvm, edd, andrewng, gbreynoo.
jhenderson added a comment.

I'm not sure I understand the motivation behind this change (or @ruiu's original change to add the symbol). Why are we creating `__real_foo` at all?



================
Comment at: test/ELF/wrap.s:23
+// SYM:      Name: __real_foo
+// SYM-NEXT: Value: 0x11020
 // SYM:      Name: __wrap_foo
----------------
This doesn't look right to me at all. `__real_foo`, `__wrap_foo` and `foo` can't all have different values. Surely there should be only two different values between these three, because there are only two functions in the code?


https://reviews.llvm.org/D34993





More information about the llvm-commits mailing list