[PATCH] D35143: [tsan] Port setjmp/longjmp assembly to Darwin/AArch64

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 10 00:46:03 PDT 2017


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:464
+# ifdef __aarch64__
+    uptr mangled_sp = env[13];
+# else
----------------
Have you tested this on freebsd? If not, please separate SANITIZER_FREEBSD and SANITIZER_MAC and add this only for SANITIZER_MAC. Let's get a build failure instead of an obscure runtime failure.


Repository:
  rL LLVM

https://reviews.llvm.org/D35143





More information about the llvm-commits mailing list