[PATCH] D34769: [X86] X86::CMOV to Branch heuristic based optimization

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86CmovConversion.cpp:338
+        bool IsCMOV = CmovInstructions.count(&MI);
+        for (auto &MO : MI.operands()) {
+          if (!MO.isReg() || !MO.isUse())
----------------
Are these two equivalent?

  for (auto &MO : MI.operands())
    if (!MO.isReg() || !MO.isUse())
      continue;

and

  for (auto &MO : MI.uses())
    if (!MO.isReg())
      continue?


================
Comment at: lib/Target/X86/X86CmovConversion.cpp:355
+
+        for (auto &MO : MI.operands()) {
+          if (!MO.isReg() || !MO.isDef())
----------------
Are these two equivalent?

  for (auto &MO: MI.operands())
    if (!MO.isReg() || !MO.isDef())
      continue;

and

  for (auto &MO: MI.defs())
   


https://reviews.llvm.org/D34769