[PATCH] D34971: Remove freed InvalidDomains from InvalidDomainMap.

[Maximilian Falkenstein via Phabricator via llvm-commits]

maxf added a comment.

I looked into providing a testcase and it seems to be infeasible, because the only test cases I can reliably reproduce this on are

- MultiSource/Applications/JM/lencod/lencod
- MultiSource/Applications/SIBsim4/SIBsim4
- MultiSource/Benchmarks/MallocBench/gs/gs
- MultiSource/Benchmarks/MiBench/automotive-susan/automotive-susan
- MultiSource/Benchmarks/Ptrdist/bc/bc
- MultiSource/Benchmarks/mafft/pairlocalalign

when running with "-polly-process-unprofitable". Those are all big multi-source tests and bugpoint also seems unable to reduce them by much. This seems to be kind of logical since this is essentially a heap corruption which is detected because glibc notices the corrupted free list, therefore we're most likely to detect it only if we're finding lots of ScOPs and then only as a side-effect, so I'm not sure how I would create a test that's suitable for our regression test suite in this case. I mean, I can include one of the above, but they are about 250KB.
POLLY_TEST_USE_VG results in make check-polly complaining, but as far as I can see due to a different issue that I have yet to track down...


https://reviews.llvm.org/D34971