[LNT] r307447 - Make LNT client print server's error messages

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 16:53:36 PDT 2017


I intentionally dumped the main layout: the main layout does not work in all cases because url_for might not have routes registered that the main layout expects.

I was thinking about refactoring the main layout one level further, but that seemed silly.

> On Jul 7, 2017, at 4:48 PM, Matthias Braun <mbraun at apple.com> wrote:
> 
> 
>> -{% block body %}
>> +<!DOCTYPE html>
>> +<html lang="en">
>> +<head>
>> +    <meta charset="UTF-8"/>
>> 
>> +    <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap.min.css')
>> +                }}" rel="stylesheet" media="screen"/>
>> +    <link href="{{ url_for('.static', filename='bootstrap/css/bootstrap-responsive.min.css')
>> +                }}" rel="stylesheet"/>
>> +</head>
>> +<body>
>> +
>> +<h1>LNT Error</h1>
>> <div class="alert alert-error">
>> -Error: {{ message }}
>> +{{ message }}
>> </div>
>> 
>> -{% endblock %}
> 
> That looks odd, the layout template should already supply the surrounding <html> or <head> parts (or they should go into different {% block %}s.
> 
> - Matthias
> 



More information about the llvm-commits mailing list