[PATCH] D34555: [NVPTX] Add lowering of i128 params.

Madhur Amilkanthwar via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 09:40:14 PDT 2017


Sorry for off conversation question but what motivated this patch? Some
apps or usecase which fails without this?

On Jul 7, 2017 10:00 PM, "Artem Belevich via Phabricator via llvm-commits" <
llvm-commits at lists.llvm.org> wrote:

> tra requested changes to this revision.
> tra added a comment.
> This revision now requires changes to proceed.
>
> In https://reviews.llvm.org/D34555#802008, @denzp wrote:
>
> > Is it safe just to change data layout at clang side? Won't it break
> backward compatibility?
>
>
> Clang and LLVM sides of this change should land together as they have to
> be in sync.
>
> Other than that, AFAICT it should be safe as it affects only i128 which is
> not currently supported, so there should be no backward compatibility
> issues. That's in theory. You may want to ask this question on cfe-dev at .
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D34555
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170707/1575fd7c/attachment.html>


More information about the llvm-commits mailing list