[PATCH] D34689: [LLD][ELF] Pre-create ThunkSections at Target specific intervals

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 7 00:52:14 PDT 2017


grimar added inline comments.


================
Comment at: ELF/Relocations.cpp:979
+    auto ThunkEnd = Thunks.end();
+    ThunkEnd = std::remove_if(ThunkBegin, ThunkEnd, [](const ThunkSection *TS) {
+      return TS->getSize() == 0;
----------------
You can use  llvm::remove_if.


================
Comment at: ELF/Relocations.cpp:1017
+  for (ThunkSection *TS : ThunkSections[ISR])
+    return TS;
+
----------------
It is equal to next, right ?

```
if (!ThunkSections[ISR].empty())
  return ThunkSections[ISR].front();
```


https://reviews.llvm.org/D34689





More information about the llvm-commits mailing list