[PATCH] D34736: [cmake] Cache results of find_darwin_sdk_dir

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 16:11:23 PDT 2017


kubamracek added inline comments.


================
Comment at: cmake/Modules/CompilerRTDarwinUtils.cmake:3-4
 
+set(DARWIN_${sdk_name}_CACHED_SYSROOT "" CACHE STRING "Darwin SDK path for SDK ${sdk_name}.")
+
 # On OS X SDKs can be installed anywhere on the base system and xcode-select can
----------------
Actually, this doesn't work, as `${sdk_name}` isn't available.  I'm afraid I'll have to keep this declaration inside the function...


https://reviews.llvm.org/D34736





More information about the llvm-commits mailing list