[PATCH] D35004: [DWARF] - Add API to allow DWARFContextInMemory to delegate relocations handling to client.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 15:57:51 PDT 2017


George Rimar <grimar at accesssoftek.com> writes:

> So it seems we can use second constructor and feed parsers with decompressed sections we already have.
> That solves 1, 2 from your list.
>
> Then looks we need to change the way of how DWARF parsers work with relocations in this case.
> When second constructor is used, RelocAddrMap remains empty and proper values are taken from
> section's data, because it is currently assumed data is relocated. In out case LLD will provide non-relocated
> content.
>
> Currently RelocAddrMap is a part of DWARFSection class. Instead of that looks
> we may introduce some helper. Which should be able to return relocation value for section
> by relocation offset. Default implementation will still use RelocAddrMap, and LLD specific can do whatever
> it wants on its side.
>
> I am going to suspend D35004 and D35005 for now (right ?) and try to prepare some patch to 
> rework how parsers handle the relocations for start. Sound fine ?

It should be possible to have a single constructor.

I will take a quick look at it and post what I can get done today.

Cheers,
Rafael


More information about the llvm-commits mailing list