[PATCH] D35064: [lib/LTO] Fix the interaction between linker redefined symbols and ThinLTO

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 12:19:38 PDT 2017


tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Lgtm with one request below.



================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:549
+    // Switch the linkage to weakany if asked for, e.g. we do this for
+    // linker redefined symbols (via --wrap or --defsym).
+    if (NewLinkage == GlobalValue::WeakAnyLinkage) {
----------------
Please add comment here indicating where this is set on the summary, since it isn't in the corresponding InIndex version of this function.


https://reviews.llvm.org/D35064





More information about the llvm-commits mailing list