[PATCH] D34838: Prototype: Reduce llvm-profdata merge memory usage further

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Limit NamedInstrProfRecord to the reader file seems ok -- but this class also looks like a useful convenience class. We can probably discuss that in a different thread if it is desirable.



================
Comment at: lib/ProfileData/InstrProfWriter.cpp:180
+Error InstrProfWriter::addRecord(NamedInstrProfRecord &&I, uint64_t Weight) {
+  // Careful/subtle code: the std::move(I) below doesn't adversely affect the
+  // Name and Hash fields, since the third parameter to addRecord takes
----------------
I don't find the comment here helping.  Perhaps just mention the move construction happens later when assigned to the Dest?


https://reviews.llvm.org/D34838