[PATCH] D35043: [ADT] Enable reverse iteration for DenseMap

[David Blaikie via llvm-commits]

On Thu, Jul 6, 2017 at 12:25 AM Mehdi AMINI via Phabricator <
reviews at reviews.llvm.org> wrote:

> mehdi_amini added a comment.
>
> I had a similar issue when I tried to change the StringMap hash function
> in LLVM and it broke a bunch of test because LLVM's behavior changes
> depending on the order of iteration there (this is deterministic but the
> hash function is part of the inputs to consider for determinism
> basically...)
>

Yeah, for sure - I'm wondering if it's worth frontloading all that work to
make it easier to modify hash functions or container bucket sizes, etc. Or
just "do the needful" (update the relevant tests, etc) whenever those
features change.


>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D35043
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170706/974b2400/attachment.html>