[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

Lama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 02:06:55 PDT 2017


lsaba added inline comments.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:86
     // offsets' differences will be taken care of during instruction
     // substitution.
+    if (HardDispCheck)
----------------
This comment is only valid for the else statement, please change it to explain the different cases between Identical and Similar Disp


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:292
+
+  bool cseLEAs(const MachineBasicBlock &MBB);
+
----------------
Please add a comment explaining what this function does


https://reviews.llvm.org/D35014





More information about the llvm-commits mailing list