[PATCH] D35019: [X86][SandyBridgel] Updating all scheduling information on each SNB instruction about latency, number of uOps and used ports

[Gadi Haber via Phabricator via llvm-commits]

gadi.haber marked an inline comment as done.
gadi.haber added inline comments.


================
Comment at: lib/Target/X86/X86SchedSandyBridge.td:264
+// HADD, HSUB PS/PD
+// x,x / v,v,v.
+def : WriteRes<WriteFHAdd, [SBPort1]> {
----------------
zvi wrote:
> To minimize the change in this patch, can you please move this block in a separate commit and then rebase this patch?
This block was not modified by this patch. You can see it in the original code starting line 160. It got shifted to line 260 due to other changes. I can try to move it back to be better aligned with the original version.


================
Comment at: test/CodeGen/X86/gather-addresses.ll:3
 ; RUN: llc -mtriple=x86_64-win32 -mcpu=nehalem < %s | FileCheck %s --check-prefix=WIN
-; RUN: llc -mtriple=i686-win32 -mcpu=nehalem < %s | FileCheck %s --check-prefix=LIN32
+; RUN: llc -mtriple=i686-win32 -mcpu=nehalem < %s | FileCheck %s --check-prefix=WIN32
 ; rdar://7398554
----------------
zvi wrote:
> Is this change intentional?
Yes,. I fixed a typo in the test.



Repository:
  rL LLVM

https://reviews.llvm.org/D35019