[PATCH] D34915: [pdb] Add a test for every known CodeView type

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 17:02:24 PDT 2017


zturner added inline comments.


================
Comment at: llvm/test/DebugInfo/PDB/Inputs/every-type.cpp:12
+                                           // LF_FIELDLIST
+  enum NestedEnum {                        // LF_ENUM
+                                           // LF_NESTTYPE
----------------
amccarth wrote:
> Class enums still use LF_ENUM, right?  Do we care about the underlying integral type?
Yes it still uses `LF_ENUM`.  And I don't think we care about the underlying type, all we care about is making sure that the reading and writing code for every leaf and member type is exercised by the test.  The underlying type is just going to be a simple type, so we don't really care what it is as we aren't serializing / deserializing it.


Repository:
  rL LLVM

https://reviews.llvm.org/D34915





More information about the llvm-commits mailing list