[PATCH] D34841: [lit/libcxx] Fix a remaining reference to lit.util.capture() in custom libcxx/Darwin code.

[Michael Zolotukhin via Phabricator via llvm-commits]

mzolotukhin added a comment.

There are still more uses of `lit.util.capture`. I fixed one of them in r307201 (it broke PGO builds), but there are still some remaining:

  ./test/lit.cfg:    llvm_src_root = lit.util.capture(['llvm-config', '--src-root']).strip()
  ./test/lit.cfg:    llvm_obj_root = lit.util.capture(['llvm-config', '--obj-root']).strip()
  ./test/Unit/lit.cfg:    llvm_src_root = lit.util.capture(['llvm-config', '--src-root']).strip()
  ./test/Unit/lit.cfg:    llvm_obj_root = lit.util.capture(['llvm-config', '--obj-root']).strip()
  ./tools/clang/test/lit.cfg:    llvm_src_root = lit.util.capture(['llvm-config', '--src-root']).strip()
  ./tools/clang/test/lit.cfg:    llvm_obj_root = lit.util.capture(['llvm-config', '--obj-root']).strip()
  ./tools/clang/test/Unit/lit.cfg:    llvm_src_root = lit.util.capture(['llvm-config', '--src-root']).strip()
  ./tools/clang/test/Unit/lit.cfg:    llvm_obj_root = lit.util.capture(['llvm-config', '--obj-root']).strip()

I wonder why they didn't cause any problems (or why we didn't find the problems). Do we need to change them the same way?

Michael


https://reviews.llvm.org/D34841