[PATCH] D34973: AMDGPU: Add macro fusion schedule DAG mutation

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 01:27:27 PDT 2017


javed.absar added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPUMacroFusion.cpp:34
+
+  switch (SecondMI.getOpcode()) {
+  case AMDGPU::V_ADDC_U32_e64:
----------------
This might be shorter and easier to read. Just a suggestion. 

 if (opcode == AMDGPU::V_ADDC_U32_e64 || ...  || ) {
    ... 
   return FirstMI->...
}
return false;



https://reviews.llvm.org/D34973





More information about the llvm-commits mailing list