[PATCH] D34816: [GlobalISel][X86] support G_FPEXT operation.

Guy Blank via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 07:34:25 PDT 2017


guyblank added inline comments.


================
Comment at: lib/Target/X86/X86RegisterBankInfo.cpp:196
+  default:
+    // Track the bank of each register, use NotFP mapping (all scalars in GPRs)
+    getInstrPartialMappingIdxs(MI, MRI, /* isFP */ false, OpRegBankIdx);
----------------
move comment up + update it? 

consider moving the switch to a helper  

```
getInstrPartialMappingIdxs(MI, MRI, isFP(Opc), OpRegBankIdx);
```


https://reviews.llvm.org/D34816





More information about the llvm-commits mailing list