[lld] r306813 - [ELF] - Resolve references properly when using .symver directive

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 00:19:14 PDT 2017


> Reverted in r306996.?


Ed, thanks for reproduce !


Rui, thanks for reverting. I found fix is one line trivial for this:


  if (Config->Shared) // This line should be added.
    error(toString(File) + ": symbol " + S + " has undefined version " +
          Verstr);

We had this chyeck in one of latest diffs during review but it was removed in final patch version,
I think we need to restore it.

reviews.llvm.org<https://reviews.llvm.org/> is currently unavailable for everyone (it seems for about a day atm),
I'll update the patch with this change and trigger "needs review" again as soon as it be alive.

George.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170703/29d20125/attachment.html>


More information about the llvm-commits mailing list