[llvm] r307003 - [InstCombine] Add a TODO for a probable missing single use check. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 2 22:54:16 PDT 2017


Author: ctopper
Date: Sun Jul  2 22:54:16 2017
New Revision: 307003

URL: http://llvm.org/viewvc/llvm-project?rev=307003&view=rev
Log:
[InstCombine] Add a TODO for a probable missing single use check. NFC

Will try to fix it soon, but in case I forget.

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp?rev=307003&r1=307002&r2=307003&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp Sun Jul  2 22:54:16 2017
@@ -82,6 +82,8 @@ static Value *getFCmpValue(unsigned Code
 Value *InstCombiner::SimplifyBSwap(BinaryOperator &I) {
   assert(I.isBitwiseLogicOp() && "Unexpected opcode for bswap simplifying");
 
+  // TODO We should probably check for single use of the bswap.
+
   Value *NewLHS;
   if (!match(I.getOperand(0), m_BSwap(m_Value(NewLHS))))
     return nullptr;




More information about the llvm-commits mailing list