[PATCH] D34922: Revert "Revert "Replace trivial use of external rc.exe by writing our own .res file.""

Eric Beckmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 20:58:50 PDT 2017


ecbeckmann created this revision.
Herald added a subscriber: hiraditya.

This reverts commit 51931072a7c9a52540baf76fc30ef391d2529a2f.

This revert was originally done because the integrations of the new
WindowsResource library into LLD was causing error in chromium, due to
bugs in how resource sections were handled.  These bugs were fixed,
meaning that the features may be reintegrated.


https://reviews.llvm.org/D34922

Files:
  lld/COFF/DriverUtils.cpp
  lld/test/COFF/combined-resources.test
  lld/test/COFF/def-name.test
  lld/test/COFF/dll.test
  lld/test/COFF/dllimport-gc.test
  lld/test/COFF/manifestinput.test
  lld/test/COFF/noentry.test
  lld/test/COFF/out.test
  lld/test/COFF/resource.test
  lld/test/lit.cfg
  llvm/include/llvm/BinaryFormat/COFF.h
  llvm/include/llvm/Object/WindowsResource.h
  llvm/lib/BinaryFormat/Magic.cpp
  llvm/lib/Object/WindowsResource.cpp
  llvm/unittests/BinaryFormat/TestFileMagic.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34922.104978.patch
Type: text/x-patch
Size: 19020 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170701/0d69e079/attachment.bin>


More information about the llvm-commits mailing list