[PATCH] D33850: Inlining: Don't re-map simplified cloned instructions.

Kyle Butt via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 16:57:27 PDT 2017


Feel free to revert it. I'll look into your reproducer to see if I
understand it.

The original code was definitely broken in the case of self-inlining, but
that is prevented now.

On Fri, Jun 30, 2017 at 4:37 PM, Davide Italiano via Phabricator <
reviews at reviews.llvm.org> wrote:

> davide added a comment.
>
> I looked at this more closely, and I personally don't see anything wrong
> with the code as-is.
> We happen to have an instruction that simplifies to a different
> instruction in the original function (mainly because instsimplify does some
> hazy threading over select/phis), so maybe this assertion is too strict?
> Kyle, what do you think?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D33850
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/8bfc3909/attachment.html>


More information about the llvm-commits mailing list