[PATCH] D34583: [LSR] Narrow search space by filtering non-optimal formulae with the same ScaledReg and Scale.

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/Transforms/LoopStrengthReduce/X86/lsr-filtering-scaledreg.ll:7
+%class.ZippyScatteredWriter = type { i8, i8*, i8* }
+ at e = local_unnamed_addr global %class.A { i8 0, i8 0, [5 x i32] zeroinitializer, i64 1, i64 0, i64 1 }, align 8
+ at f = local_unnamed_addr global %class.ZippyScatteredWriter* null, align 8
----------------
wmi wrote:
> sanjoy wrote:
> > Can you please clean up the names a bit here?  Perhaps using metarenamer?
> > 
> > Also, are both the loops necessary to show the difference in behavior?
> metarenamer is a great tool. Thanks for the suggestion.
> 
> I reduce the test to some extend, but the second loop is still necessary to create a complex enough searching space.
> I reduce the test to some extend, but the second loop is still necessary to create a complex enough searching space.

Sounds good!


Repository:
  rL LLVM

https://reviews.llvm.org/D34583