[PATCH] D34482: [Dominators] Add parent and sibling property verification (non-hacky)

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 16:50:23 PDT 2017


I added some simple explanation and references in r306912 and wordsmithed
it a bit in r306916.
Please let me know if you think they are sufficient :)


On Fri, Jun 30, 2017 at 1:24 AM, Tobias Grosser via Phabricator <
reviews at reviews.llvm.org> wrote:

> grosser added a comment.
>
> Hi Kuhar,
>
> I unfortunately just saw this new patch (and all your others) as I was
> traveling for a little while. Thanks for providing verifiers that check
> some of the invariants you expect from a dominator tree. In my discussion
> with Daniel pointed out a scientific paper which explicitly discusses the
> parent and sibling properties you mention here: "Dominator Tree
> Certification and Independent Spanning Trees". I think it would be great to
> reference this (or earlier work) in the commit to help people who would
> like to have more background.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D34482
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/33272fba/attachment.html>


More information about the llvm-commits mailing list