[PATCH] D34910: Make LLVM_TARGETS_TO_BUILD=all build all targets

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 16:40:45 PDT 2017


mehdi_amini added a comment.

In https://reviews.llvm.org/D34910#797402, @silvas wrote:

> IIRC the intention was that in-tree work should not be burdened by experimental targets, up to and including breaking them. E.g. an in-tree API migration wouldn't have to update experimental targets. So in that sense `LLVM_TARGETS_TO_BUILD=all` is working as intended I think.


Yes this is correct: but what matters on this aspect is the *default* isn't it? A bot does not have to specify LLVM_TARGETS_TO_BUILD, and as long as the default does not include the experimental target that seems fine to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D34910





More information about the llvm-commits mailing list