[lld] r306854 - Tighten up tests for .rsrc section emission.

Eric Beckmann via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 11:22:11 PDT 2017


Author: ecbeckmann
Date: Fri Jun 30 11:22:11 2017
New Revision: 306854

URL: http://llvm.org/viewvc/llvm-project?rev=306854&view=rev
Log:
Tighten up tests for .rsrc section emission.

Summary:
There have been bugs with the WindowsResource library, such as incorrect
symbols for addresses.  Directly checking the .rsrc in the final PE will
help ensure this doesn't happen again.

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D34900

Modified:
    lld/trunk/test/COFF/resource.test

Modified: lld/trunk/test/COFF/resource.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/resource.test?rev=306854&r1=306853&r2=306854&view=diff
==============================================================================
--- lld/trunk/test/COFF/resource.test (original)
+++ lld/trunk/test/COFF/resource.test Fri Jun 30 11:22:11 2017
@@ -9,8 +9,8 @@
 EXE: {{H.e.l.l.o}}
 
 # Verify the resource tree layout in the final executable.
-# RUN: llvm-readobj -file-headers -coff-resources %t.exe | FileCheck \
-# RUN:   --check-prefix=RESOURCE_INFO %s
+# RUN: llvm-readobj -file-headers -coff-resources -section-data %t.exe | \
+# RUN:   FileCheck --check-prefix=RESOURCE_INFO %s
 
 RESOURCE_INFO:      ResourceTableRVA: 0x1000
 RESOURCE_INFO-NEXT: ResourceTableSize: 0x88
@@ -33,3 +33,14 @@ RESOURCE_INFO-NEXT:         Time/Date St
 RESOURCE_INFO-NEXT:         Major Version: 0
 RESOURCE_INFO-NEXT:         Minor Version: 0
 RESOURCE_INFO-NEXT:         Characteristics: 0
+RESOURCE_INFO-DAG: .rsrc Data (
+RESOURCE_INFO-NEXT: 0000: 00000000 00000000 00000000 00000100  |................|
+RESOURCE_INFO-NEXT: 0010: 06000000 18000080 00000000 00000000  |................|
+RESOURCE_INFO-NEXT: 0020: 00000000 00000100 01000000 30000080  |............0...|
+RESOURCE_INFO-NEXT: 0030: 00000000 00000000 00000000 00000100  |................|
+RESOURCE_INFO-NEXT: 0040: 09040000 48000000 58100000 2A000000  |....H...X...*...|
+RESOURCE_INFO-NEXT: 0050: 00000000 00000000 00000500 48006500  |............H.e.|
+RESOURCE_INFO-NEXT: 0060: 6C006C00 6F000000 00000000 00000000  |l.l.o...........|
+RESOURCE_INFO-NEXT: 0070: 00000000 00000000 00000000 00000000  |................|
+RESOURCE_INFO-NEXT: 0080: 00000000 00000000                    |........|
+RESOURCE_INFO-NEXT: )




More information about the llvm-commits mailing list