[PATCH] D34685: Mark a number of x86 only tests to require x86

Dave Bozier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 08:54:41 PDT 2017


davidb added a comment.

In https://reviews.llvm.org/D34685#796778, @ruiu wrote:

> I don't know if I understand what you said correctly. I do not want to force anyone to enable the x86 target. If you disable x86, tests that use x86 as a "generic" target won't run, but it shouldn't be more than that. I'm still waiting for you to update this patch to address Rafael's comment.


I'll update the patch. But I'm still concerned that needing to add "REQUIRES: x86" is going to be an ongoing maintenance for us as new tests are added.

Also as it currently stands, I can't see an easy way to distinguish between generic tests and actual x86 tests.


https://reviews.llvm.org/D34685





More information about the llvm-commits mailing list