[PATCH] D34391: [RegisterCoalescer] Fix for SubRange join unreachable

David Stuttard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 08:35:52 PDT 2017


dstuttard added a reviewer: arsenm.
dstuttard added a comment.

In https://reviews.llvm.org/D34391#791480, @MatzeB wrote:

> The code fix LGTM, but please wait for @qcolombet/@arsenm before committing.
>
> Making a .mir test seems indeed hard at the moment, as the printer already fails; manually stripping memory operands only works after printing I presume?


Yes, stripping the operands only works after printing :(

@arsenm I'll try using volatile loads and stores to see if that works in this case. Would it be acceptable in the meantime to accept this change and then I'll update the .ll test with a .mir one when it works?


https://reviews.llvm.org/D34391





More information about the llvm-commits mailing list