[llvm] r306529 - [X86] Correct dwarf unwind information in function epilogue

Daniel Jasper via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 30 01:38:25 PDT 2017


On Fri, Jun 30, 2017 at 12:54 AM, Petar Jovanovic <
Petar.Jovanovic at imgtec.com> wrote:

> > The buildbot is not quite done with the revision, but the checks that
> failed before are now green again:
> > http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3125
>
> Yes, it was due to this change.
>
> > If it doesn't go back to green, we can recommit (and fix the original
> > commit message at the same time :) ).
>
> What would you change in the commit message?


Well, basically incorporating what Chandler is saying. The message should
make clear why it is X86 specific if it really is and why changing
non-target-specific paths should not have an effect on other targets. Took
us some time to understand that the PPC breakage we were seeing was coming
from a change labeled [X86]...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170630/eade0305/attachment.html>


More information about the llvm-commits mailing list