[PATCH] D34600: [Error] add expectSuccess()

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 17:38:29 PDT 2017


chandlerc added a comment.

In https://reviews.llvm.org/D34600#796195, @lhames wrote:

> FWIW I found that in practice it obvious from context that cantFail would return the wrapped result:
>
>   auto X = cantFail(foo(...));
>   
>
> Once people know to look for an 'assertSuccess' type function, the lack of an 'AndGet' suffix seems unlikely to confuse them.


I think it will be a bit more confusing in other contexts:

  return assertSuccess(foo(...)); // void or T? Both compile...


https://reviews.llvm.org/D34600





More information about the llvm-commits mailing list