[PATCH] D34586: Remove info_keys; NFC

Chris Matthews via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 14:39:56 PDT 2017


cmatthews accepted this revision.
cmatthews added a comment.
This revision is now accepted and ready to land.

Besides not performing the drop, LGTM.



================
Comment at: lnt/server/db/migrations/upgrade_12_to_13.py:13
+        session.connection().execute("""
+ALTER TABLE TestSuiteMachineFields DROP COLUMN info_key;
+ALTER TABLE TestSuiteOrderFields DROP COLUMN info_key;
----------------
Could you land the DROPing part of the much later, once this has made it into the wild and everyone is happy.  There is no revert from a DROP!


Repository:
  rL LLVM

https://reviews.llvm.org/D34586





More information about the llvm-commits mailing list