[PATCH] D34667: [Demangler] [DO NOT SUBMIT] Initial patch for Microsoft demangler.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> So the idea is to convert the mangled name to an AST and then convert the AST to a string. That makes sense. But is the string form of the result always enough? Will there ever be a need for a caller to get the AST or some other representation?

This is an interesting question. It could imagine that it might be useful, but honestly I don't come up with a use case in which you want to access internal ASTs.



================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:33
+// This class provides a few utility functions for string manipulations.
+class String {
+public:
----------------
compnerd wrote:
> Isnt this effectively `std::string_view` or `StringRef`?
Yes it is. This file is designed to be usable outside LLVM.


https://reviews.llvm.org/D34667