[test-suite] r306730 - [lit, test-suite] Fix a reference to FileBasedTest that I missed earlier.

David L. Jones via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 29 12:33:46 PDT 2017


Author: dlj
Date: Thu Jun 29 12:33:46 2017
New Revision: 306730

URL: http://llvm.org/viewvc/llvm-project?rev=306730&view=rev
Log:
[lit, test-suite] Fix a reference to FileBasedTest that I missed earlier.

Summary:
The test-suite implements its own specialized lit format for running tests,
which was based on FileBasedTest. Since that base was removed, the format now
needs to use something that is still available.

The only functionality that comes from FileBasedTest is the test discovery,
which was moved into ShTest. For now, it seems to make the most sense simply to
use ShTest as the base for TestSuiteTest.

I think a better solution is to factor out the test discovery logic, although
that will require a bit more work (and has effects across projects).

Reviewers: leandron

Subscribers: llvm-commits, sanjoy

Differential Revision: https://reviews.llvm.org/D34830

Modified:
    test-suite/trunk/litsupport/test.py

Modified: test-suite/trunk/litsupport/test.py
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=306730&r1=306729&r2=306730&view=diff
==============================================================================
--- test-suite/trunk/litsupport/test.py (original)
+++ test-suite/trunk/litsupport/test.py Thu Jun 29 12:33:46 2017
@@ -7,7 +7,7 @@ import lit
 import lit.util
 import logging
 import os
-from lit.formats import FileBasedTest
+from lit.formats import ShTest
 from lit.TestRunner import getTempPaths
 from lit import Test
 from lit.util import to_bytes, to_string
@@ -59,7 +59,7 @@ def load_modules(test_modules):
         modules.append(module)
 
 
-class TestSuiteTest(FileBasedTest):
+class TestSuiteTest(ShTest):
     def __init__(self):
         super(TestSuiteTest, self).__init__()
 




More information about the llvm-commits mailing list